deniskuzZ commented on code in PR #5123:
URL: https://github.com/apache/hive/pull/5123#discussion_r1532347495
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractBaseAlterTableAnalyzer.java:
##########
@@ -95,11 +98,16 @@ protected void addInputsOutputsAlterTable(TableName
tableName, Map<String, Strin
// ReadEntity as no lock.
re.noLockNeeded();
inputs.add(re);
+ Partition partition;
if (AlterTableUtils.isFullPartitionSpec(table, partitionSpec)) {
// Fully specified partition spec
- Partition part = PartitionUtils.getPartition(db, table, partitionSpec,
true);
- outputs.add(new WriteEntity(part, writeType));
+ if (table.getStorageHandler() != null &&
table.getStorageHandler().alwaysUnpartitioned()) {
Review Comment:
why not to make `PartitionUtils.getPartition(db, table, partitionSpec,
true)` generic. it should return partitions based on table type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
