mdayakar commented on code in PR #5182: URL: https://github.com/apache/hive/pull/5182#discussion_r1570924896
########## hplsql/src/main/java/org/apache/hive/hplsql/functions/FunctionMisc.java: ########## @@ -211,6 +269,16 @@ public void partCount(HplsqlParser.Expr_spec_funcContext ctx) { query.close(); } + public void modulo(HplsqlParser.Expr_func_paramsContext ctx) { + if (ctx.func_param().size() == 2) { + int a = evalPop(ctx.func_param(0).expr()).intValue(); + int b = evalPop(ctx.func_param(1).expr()).intValue(); + evalInt(a % b); + } else { + evalNull(); Review Comment: These are the APIs removed as a part of [HIVE-27492](https://issues.apache.org/jira/browse/HIVE-27492) fix. So just added back them again.Didn't do any code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org