mdayakar commented on code in PR #5182:
URL: https://github.com/apache/hive/pull/5182#discussion_r1570337451
##########
hplsql/src/main/java/org/apache/hive/hplsql/Expression.java:
##########
@@ -110,7 +110,17 @@ else if (ctx.interval_item() != null) {
}
else {
visitChildren(ctx);
- sql.append(exec.stackPop().toString());
+ Var value = exec.stackPop();
+ if (value.type == Type.NULL && sql.toString().length() == 0) {
+ exec.stackPush(new Var());
+ return;
+ } else if (exec.buildSql && value.type == Type.DATE) {
+ sql.append(String.format("DATE '%s'", value.toString()));
+ } else if (exec.buildSql && value.type == Type.TIMESTAMP) {
+ sql.append(String.format("TIMESTAMP '%s'", value.toString()));
+ } else {
+ sql.append(value.toString());
+ }
Review Comment:
As a part of HIVE-27492 fix, added these format in Var.toString() API itself
but this format is required only if the UDF used in as a select statement (DATE
'2024-04-18' is valid where as 2024-04-18 is not a valid value in selection) so
changed accordingly(now added only for select flow).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
