mdayakar commented on code in PR #5182:
URL: https://github.com/apache/hive/pull/5182#discussion_r1570916828
##########
hplsql/src/main/java/org/apache/hive/hplsql/Var.java:
##########
@@ -612,7 +613,7 @@ else if (type == Type.TIMESTAMP) {
if (t.length() > len) {
t = t.substring(0, len);
}
- return String.format("TIMESTAMP '%s'", t);
+ return t;
Review Comment:
As explained in
https://github.com/apache/hive/pull/5182#discussion_r1570337451 comment, this
was added by me only just reverted back the change done as a part of
[HIVE-27492](https://issues.apache.org/jira/browse/HIVE-27492) fix.
##########
hplsql/src/main/java/org/apache/hive/hplsql/Var.java:
##########
@@ -601,7 +602,7 @@ else if (type == Type.STRING) {
return (String)value;
}
else if (type == Type.DATE) {
- return String.format("DATE '%s'", value);
+ return ((Date)value).toString();
Review Comment:
As explained in
https://github.com/apache/hive/pull/5182#discussion_r1570337451 comment, this
was added by me only just reverted back the change done as a part of
[HIVE-27492](https://issues.apache.org/jira/browse/HIVE-27492) fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
