deniskuzZ commented on code in PR #5205:
URL: https://github.com/apache/hive/pull/5205#discussion_r1615911863
##########
itests/hive-unit/src/test/java/org/apache/hive/service/cli/thrift/TestThriftCliServiceMessageSize.java:
##########
@@ -35,24 +34,13 @@
import org.junit.BeforeClass;
import org.junit.Test;
-public class TestThriftCliServiceMessageSize {
- protected static int port;
- protected static String host = "localhost";
- protected static HiveServer2 hiveServer2;
- protected static ThriftCLIServiceClient client;
- protected static HiveConf hiveConf;
- protected static String USERNAME = "anonymous";
- protected static String PASSWORD = "anonymous";
-
+public class TestThriftCliServiceMessageSize extends ThriftCLITestUtils {
/**
* @throws java.lang.Exception
*/
@BeforeClass
public static void setUpBeforeClass() throws Exception {
- // Find a free port
- port = MetaStoreTestUtils.findFreePort();
- hiveServer2 = new HiveServer2();
- hiveConf = new HiveConf();
+ ThriftCLITestUtils.setUpBeforeClass();
Review Comment:
same thing, why to override?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
