deniskuzZ commented on code in PR #5205: URL: https://github.com/apache/hive/pull/5205#discussion_r1616990659
########## service/src/test/org/apache/hive/service/cli/thrift/ThriftCLITestUtils.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hive.service.cli.thrift; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hive.service.server.HiveServer2; + +import java.io.IOException; +import java.net.ServerSocket; + +import org.junit.BeforeClass; + +public abstract class ThriftCLITestUtils { + protected static int port; + protected static HiveServer2 hiveServer2; + protected static HiveConf hiveConf; + protected static String host = "localhost"; + protected static ThriftCLIServiceClient client; + protected static String USERNAME = "anonymous"; + protected static String PASSWORD = "anonymous"; + protected static final int RETRY_COUNT = 10; + + /** + * @throws java.lang.Exception + */ + @BeforeClass + public static void setUpBeforeClass() throws Exception { + // Find a free port + port = findFreePort(); + hiveServer2 = new HiveServer2(); + hiveConf = new HiveConf(); + } + + protected static void startHiveServer2WithConf(HiveConf hiveConf) throws Exception { Review Comment: what is that 'protected static'? you can't override static methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
