deniskuzZ commented on code in PR #5205:
URL: https://github.com/apache/hive/pull/5205#discussion_r1616953102
##########
itests/hive-unit/src/test/java/org/apache/hive/service/cli/thrift/TestThriftHttpCLIServiceFeatures.java:
##########
@@ -138,16 +138,15 @@ public boolean hasCookieHeader() {
@BeforeClass
public static void setUpBeforeClass() throws Exception {
// Set up the base class
- ThriftCLIServiceTest.setUpBeforeClass();
+ ThriftCLITestUtils.setUpBeforeClass();
Review Comment:
it's static, it can't override the parent.
why do you annotate `@BeforeClass setUpBeforeClass` in `ThriftCLITestUtils`
then? Maybe you should remove this and don't extend from that class, use it as
Util
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
