kgyrtkirk commented on code in PR #5332: URL: https://github.com/apache/hive/pull/5332#discussion_r1670154663
########## Jenkinsfile: ########## @@ -17,6 +17,9 @@ */ properties([ + // For master keep all builds for one year + // For other branches/PRs keep at most 5 builds for at most two months + buildDiscarder(logRotator(daysToKeepStr: env.BRANCH_NAME=='master'?'365':'60', numToKeepStr: env.BRANCH_NAME=='master'?'':'5')), Review Comment: instead of 2 `?:` ; why not have a full `if` ? more readble; and then the comment could be in the branches too - or can be even relaxed edit: :facepalm: I guess the fact that this is an *array* of properties kinda fight against such solution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
