kgyrtkirk commented on code in PR #5332: URL: https://github.com/apache/hive/pull/5332#discussion_r1680955735
########## Jenkinsfile: ########## @@ -17,6 +17,9 @@ */ properties([ + // For master keep all builds for one year + // For other branches/PRs keep at most 5 builds for at most two months + buildDiscarder(logRotator(daysToKeepStr: env.BRANCH_NAME=='master'?'365':'60', numToKeepStr: env.BRANCH_NAME=='master'?'':'5')), Review Comment: I think above one tells the story better; following the names of the exising api is also beneficial; `discardDaysToKeep` / `discardNumToKeep` but I've no strong opinion - this is a rarely changing thing...so it can be anyhow if it works as intended... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
