zabetak commented on code in PR #5332:
URL: https://github.com/apache/hive/pull/5332#discussion_r1678175222
##########
Jenkinsfile:
##########
@@ -17,6 +17,9 @@
*/
properties([
+ // For master keep all builds for one year
+ // For other branches/PRs keep at most 5 builds for at most two months
+ buildDiscarder(logRotator(daysToKeepStr:
env.BRANCH_NAME=='master'?'365':'60', numToKeepStr:
env.BRANCH_NAME=='master'?'':'5')),
Review Comment:
@kgyrtkirk Is the refactoring below what you had in mind?
```groovy
def discardBuildsDaysLimit = '365'
def discardBuildsEntriesLimit = ''
if (env.BRANCH_NAME != 'master') {
discardBuildsDaysLimit = '60'
discardBuildsEntriesLimit = '5'
}
properties([
buildDiscarder(logRotator(daysToKeepStr: discardBuildsDaysLimit,
numToKeepStr: discardBuildsEntriesLimit))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
