zhangbutao commented on PR #5436: URL: https://github.com/apache/hive/pull/5436#issuecomment-2345097437
> > @zhangbutao, do we need this: `d7d34f274349ce7de1f29d113395e7f28c Hive: turn off the stats gathering when iceberg.hive.keep.stats is false`? I think you mentioned that we should collect stats regardless > > @deniskuzZ I didn't backport this commit. I think https://github.com/apache/hive/pull/4348/files can fix the same issue. But i will double check this later. @deniskuzZ I have checked this. We already fix this by https://github.com/apache/hive/pull/4348/files in this code snippet: https://github.com/apache/hive/blob/4b089c2a48b8d36e5084ce06945722b0ae3f0836/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L1368-L1370 That is to say, if hive.iceberg.stats.source=iceberg, we won't collects the iceberg stats & won't put stats into hms, and this can avoid the slowdown when creating the iceberg table. BTW, if we want to put iceberg stats into hms, i think `analyze `cmd can do this. So i think we no need this commit anymore `d7d34f274349ce7de1f29d113395e7f28c Hive: turn off the stats gathering when iceberg.hive.keep.stats is false` . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
