zhangbutao commented on code in PR #5436:
URL: https://github.com/apache/hive/pull/5436#discussion_r1776647304
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -254,6 +277,17 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
}
}
+ private void validateTableIsIcebergTableOrView(
Review Comment:
I just copy this code from upstream iceberg.
`IcebergTableUtil `is in `iceberg-handler` module, which can not be used in
`iceberg-catalog`.
BTW, We also have similar iceberg table validate funtion in
`MetaStoreUtils::isIcebergTable`. I think we can unify the validate iceberg
function once the native iceberg view is integrated. This can be don in the
following backport work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
