zhangbutao commented on code in PR #5436:
URL: https://github.com/apache/hive/pull/5436#discussion_r1776598730
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -270,7 +275,9 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
LOG.error("Cannot tell if commit to {}.{} succeeded, attempting to
reconnect and check.",
database, tableName, e);
- commitStatus = checkCommitStatus(newMetadataLocation, metadata);
+ commitStatus =
+ BaseMetastoreOperations.CommitStatus.valueOf(
Review Comment:
No. BaseMetastoreTableOperations also has the enum `CommitStatus ` which
has been deprecated, we need to specify the full prefix to use
`BaseMetastoreOperations.CommitStatus `
https://github.com/apache/iceberg/blob/8e9d59d299be42b0bca9461457cd1e95dbaad086/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java#L291-#L293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
