deniskuzZ commented on code in PR #5498:
URL: https://github.com/apache/hive/pull/5498#discussion_r1809420110
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java:
##########
@@ -51,11 +48,15 @@ public DummyPartition(Table tbl, String name) {
this.name = name;
}
- public DummyPartition(Table tbl, String name,
- Map<String, String> partSpec) {
- setTable(tbl);
+ public DummyPartition(Table tbl, String name, Map<String, String> partSpec)
throws HiveException {
Review Comment:
we use overriden `getValues` and `getSpec`. And yes, they represent real
partitions (not in HMS)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
