kasakrisz commented on code in PR #5498:
URL: https://github.com/apache/hive/pull/5498#discussion_r1810368157
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnInfo.java:
##########
@@ -166,9 +170,13 @@ public String getTabAlias() {
}
public boolean getIsVirtualCol() {
- return isVirtualCol;
+ return isVirtualCol || isPartitionCol;
Review Comment:
I still has the impression that this change is not safe. Example:
here we create a new instance of `ColumnInfo` based on an existing one. If
the source `ColumnInfo` is a partition column the field `isPartitionCol` is
still `false` in the result which is not valid.
https://github.com/apache/hive/blob/b2a5933c0f396ade25273ac75cbf35e205969b21/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java#L196-L197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
