deniskuzZ commented on code in PR #5498:
URL: https://github.com/apache/hive/pull/5498#discussion_r1810238687
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java:
##########
@@ -51,11 +48,15 @@ public DummyPartition(Table tbl, String name) {
this.name = name;
}
- public DummyPartition(Table tbl, String name,
- Map<String, String> partSpec) {
- setTable(tbl);
+ public DummyPartition(Table tbl, String name, Map<String, String> partSpec)
throws HiveException {
Review Comment:
`DummyPartition` is used to represent non-HMS partitions. Before iceberg, it
had just two properties: `table` and `name`.
But I agree the name is not self explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
