asolimando commented on code in PR #5444:
URL: https://github.com/apache/hive/pull/5444#discussion_r1875681991
##########
ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/stats/TestFilterSelectivityEstimator.java:
##########
@@ -159,7 +159,7 @@ public void testIsHistogramAvailableWhenEmptyArray() {
@Test
public void testLessThanSelectivity() {
- Assert.assertEquals(0.6153846153846154, lessThanSelectivity(KLL, 3),
DELTA);
Review Comment:
@okumin, if they are open to that change, we could definitely try and that
would solve our problems. But since the behavior changed in a major release,
technically it's something that could be intended and expected, although it
makes our life more complicated.
@zhangbutao sorry I missed your previous message! What about moving the
evaluate method into a map which is filled when invoking `register` for each
skect function we support? It's less elegant maybe than the existing, but we
would regain full control on what we invoke at eval time and we are anyway
already specifying many info in the register function, so it does seem to be
coherent with the current design.
What do you guys think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
