zhangbutao commented on code in PR #5444:
URL: https://github.com/apache/hive/pull/5444#discussion_r1877183787
##########
ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/stats/TestFilterSelectivityEstimator.java:
##########
@@ -159,7 +159,7 @@ public void testIsHistogramAvailableWhenEmptyArray() {
@Test
public void testLessThanSelectivity() {
- Assert.assertEquals(0.6153846153846154, lessThanSelectivity(KLL, 3),
DELTA);
Review Comment:
> What about moving the evaluate method into a map which is filled when
invoking register for each skect function we support?
@asolimando But we don't know what `evaluate `methods of sketch funtion we
should support. In fact, we can run all `evaluate` methods of each function,
but we just pick the first one & we can not determine which `evaluate ` method
is better or is what we need.
> The Hive community may have some control over the library
datasketches-hive.
@okumin I think this is too hard :(. I don't think we can do anything about
the datasketches. Unless we backport the whole base code of datasketches-hive
into Hive repo, but this may cause some codes inconsistency&conflict with
datasketches in the futrue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
