zhangbutao commented on code in PR #5444:
URL: https://github.com/apache/hive/pull/5444#discussion_r1879604779
##########
ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/stats/TestFilterSelectivityEstimator.java:
##########
@@ -159,7 +159,7 @@ public void testIsHistogramAvailableWhenEmptyArray() {
@Test
public void testLessThanSelectivity() {
- Assert.assertEquals(0.6153846153846154, lessThanSelectivity(KLL, 3),
DELTA);
Review Comment:
> what we would need to do, is to intercept where this UDF/UDAF are written
in the AST/plan and replace $udf($binary, $float) with $udf($binary, false,
$float) so that the right evaluate function is then invoked.
This seems like a good idea. :) I will try to explore this way, too.
Because incompatible datasketches changes lead to a lot of work, it seems
difficult to control datasketches-hive. I hope this PR is the last one to do
this work. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
