okumin commented on code in PR #5541:
URL: https://github.com/apache/hive/pull/5541#discussion_r1879253443
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:
##########
@@ -1840,6 +1841,14 @@ tableImplBuckets
-> ^(TOK_ALTERTABLE_BUCKETS $num)
;
+tableWriteOrdered
+@init { pushMsg("table sorted specification", state); }
+@after { popMsg(state); }
+ :
+ KW_WRITE KW_ORDERED KW_BY sortCols=columnNameOrderList
Review Comment:
> The mentioned examples do not cover all of that. E.g. I could not find in
the linked Trino documentation how the ordering is defined (ASC/DESC) or the
null ordering (NULLS FIRST/LAST)
I think this is a critical point, and now I am biased toward to `WRITE
ORDERED BY` + `WRITE LOCALLY ORDERED BY`(I wondered how to encode LOCALLY in
the metadata of Iceberg). I am trying to talk to Trino maintainers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
