zratkai commented on code in PR #5541: URL: https://github.com/apache/hive/pull/5541#discussion_r1880096326
########## parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g: ########## @@ -1840,6 +1841,14 @@ tableImplBuckets -> ^(TOK_ALTERTABLE_BUCKETS $num) ; +tableWriteOrdered +@init { pushMsg("table sorted specification", state); } +@after { popMsg(state); } + : + KW_WRITE KW_ORDERED KW_BY sortCols=columnNameOrderList Review Comment: @ayushtkn thanks Ayush for the comment! I agree with you and @deniskuzZ, LOCALLY ORDERED BY is the right choice here. @okumin @zhangbutao if you can accept that I will modify it accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org