ayushtkn commented on code in PR #5541:
URL: https://github.com/apache/hive/pull/5541#discussion_r1879768922
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:
##########
@@ -1840,6 +1841,14 @@ tableImplBuckets
-> ^(TOK_ALTERTABLE_BUCKETS $num)
;
+tableWriteOrdered
+@init { pushMsg("table sorted specification", state); }
+@after { popMsg(state); }
+ :
+ KW_WRITE KW_ORDERED KW_BY sortCols=columnNameOrderList
Review Comment:
If there is no common agreement, We can reach out the dev mailing list & can
proceed with what majority of the folks like, This Syntax discussion is kind of
pure personal preference stuff I believe, what each of us find more convenient
& there is no way we can conclude like this which is better.
Was reading this doc:
https://www.tabular.io/apache-iceberg-cookbook/data-engineering-table-write-order/
It had something like
```
ALTER TABLE logs WRITE LOCALLY ORDERED BY level, event_ts
```
&
here:
https://iceberg.apache.org/docs/latest/spark-ddl/#alter-table-write-ordered-by
```
ALTER TABLE prod.db.sample WRITE LOCALLY ORDERED BY category, id
```
If LOCALLY isn't specified it is Global Sort order as the doc says 'To order
within each task, not across tasks, use LOCALLY ORDERED BY:' and I believe this
PR is just supporting LOCAL sort order not the Global one.
So, this kind of looks fine to me, We can just suffix in the Create command
as well something like "WRITE LOCALLY ORDERED BY level, event_ts" which will be
in sync with ALTER command & all such above docs.
Again just my preference, if all of us aren't convinced on one choice, we
can fallback to dev@ and go what the majority feels more soothing to eyes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
