difin commented on code in PR #5608:
URL: https://github.com/apache/hive/pull/5608#discussion_r1922883862
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java:
##########
@@ -128,6 +128,11 @@ public ByteWritable evaluate(IntWritable i) {
if (i == null) {
return null;
} else {
+ int value = i.get();
+ if (value < Byte.MIN_VALUE || value > Byte.MAX_VALUE) {
+ throw new IllegalArgumentException("Value out of range for Byte: " +
value);
Review Comment:
It is better to use Hive-specific exceptions. Hive has an exception
`UDFArgumentException` which seems suitable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
