difin commented on code in PR #5608: URL: https://github.com/apache/hive/pull/5608#discussion_r1922884667
########## ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java: ########## @@ -146,6 +146,10 @@ public IntWritable evaluate(LongWritable i) { if (i == null) { return null; } else { + long value = i.get(); + if (value < Integer.MIN_VALUE || value > Integer.MAX_VALUE) { + throw new IllegalArgumentException("Value out of range for Integer: " + value); Review Comment: Same here, generic exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org