difin commented on code in PR #5608:
URL: https://github.com/apache/hive/pull/5608#discussion_r1922884912


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java:
##########
@@ -128,6 +128,10 @@ public ShortWritable evaluate(IntWritable i) {
     if (i == null) {
       return null;
     } else {
+      int value = i.get();
+      if (value < Short.MIN_VALUE || value > Short.MAX_VALUE) {
+        throw new IllegalArgumentException("Value out of range for Short: " + 
value);

Review Comment:
   same, can you please use Hive specific exceptions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to