deniskuzZ commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1923775913
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:
##########
@@ -330,6 +330,13 @@ public void analyze(ASTNode ast, Context ctx) throws
SemanticException {
initCtx(ctx);
init(true);
analyzeInternal(ast);
+ setQueryPropertiesAfterAnalyze();
+ }
+
+ private void setQueryPropertiesAfterAnalyze() {
+ if (queryProperties != null && getQB() != null){
+ queryProperties.extractInfoFromQueryBlock(getQB());
Review Comment:
why not just add this in `analyzeInternal`, naming is wierd containing the
sequence order
also should it be `queryProperties.addInfoFromQueryBlock`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
