abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1927410504
##########
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:
##########
@@ -755,6 +753,13 @@ int closeInProcess(boolean destroyed) {
// is called to stop the query if it is running, clean query results, and
release resources.
@Override
public void close() {
+ if
(driverContext.getConf().getBoolVar(HiveConf.ConfVars.HIVE_QUERY_HISTORY_SERVICE_ENABLED))
{
+ if (driverState.isClosed() || driverState.isDestroyed()){
+ LOG.warn("Driver instance {} already closed or destroyed, prevent
handling query history", this);
+ } else{
+ QueryHistoryService.handle(driverContext);
Review Comment:
renamed to handleQuery, I don't know better at the moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
