abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1927425373
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -600,6 +601,11 @@ default void storageHandlerCommit(Properties
commitProperties, Operation operati
throw new UnsupportedOperationException();
}
+ default void storageHandlerCommit(Properties commitProperties, Operation
operation, TaskAttemptContext context)
Review Comment:
copying response from another comment:
```we cannot depend on iceberg in hive-exec in compile-time, there is no
iceberg* dependency in hive-exec/pom.xml, that's what's hidden by the
storagehandler layer, I think, even if I really like iceberg's api, I'm limited
to use the storagehandler
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
