abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1927424022
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -838,6 +845,9 @@ public void storageHandlerCommit(Properties
commitProperties, Operation operatio
}
HiveIcebergOutputCommitter committer = getOutputCommitter();
try {
+ if (context != null) {
+ committer.commitTask(context);
Review Comment:
we cannot depend on iceberg in hive-exec in compile-time, there is no
iceberg* dependency in hive-exec/pom.xml, that's what's hidden by the
storagehandler layer, I think, even if I really like iceberg's api, I'm limited
to use the storagehandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
