deniskuzZ commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1932610236
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorContext.java:
##########
@@ -37,6 +37,7 @@ public class CompactorContext {
private final ValidWriteIdList validWriteIdList;
private final CompactionInfo compactionInfo;
private final AcidDirectory dir;
+ public static final String COMPACTION_FILE_SIZE_THRESHOLD =
"compaction.file.size.threshold";
Review Comment:
MIN_FILE_SIZE_BYTES = "min.file.size.bytes"
please check Tuning compaction behavior
https://docs.aws.amazon.com/prescriptive-guidance/latest/apache-iceberg-on-aws/best-practices-compaction.html
I don't see MIN_INPUT_FILES, we have it in ACID
````
String deltaNumProp =
tblProperties.get(COMPACTOR_THRESHOLD_PREFIX +
HiveConf.ConfVars.HIVE_COMPACTOR_DELTA_NUM_THRESHOLD);
int deltaNumThreshold = deltaNumProp == null ? HiveConf.getIntVar(conf,
HiveConf.ConfVars.HIVE_COMPACTOR_DELTA_NUM_THRESHOLD) :
Integer.parseInt(deltaNumProp);
boolean enough = deltas.size() > deltaNumThreshold;
if (!enough) {
LOG.debug(
"Not enough deltas to initiate compaction for table=" +
ci.tableName + "partition=" + ci.partName
+ ". Found: " + deltas.size() + " deltas, threshold is " +
deltaNumThreshold);
return null;
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
