deniskuzZ commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1932660172
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -460,11 +468,16 @@ compactPool
-> ^(TOK_COMPACT_POOL $poolName)
;
+fileSizeThresholdClause
+ : KW_FILE_SIZE_THRESHOLD EQUAL value=StringLiteral
+ -> ^(TOK_FILE_SIZE_THRESHOLD $value)
+ ;
+
alterStatementSuffixCompact
@init { gParent.msgs.push("compaction request"); }
@after { gParent.msgs.pop(); }
- : KW_COMPACT compactType=StringLiteral tableImplBuckets? blocking?
compactPool? (KW_WITH KW_OVERWRITE KW_TBLPROPERTIES tableProperties)?
orderByClause? whereClause?
- -> ^(TOK_ALTERTABLE_COMPACT $compactType tableImplBuckets? blocking?
compactPool? tableProperties? orderByClause? whereClause?)
+ : KW_COMPACT compactType=StringLiteral tableImplBuckets? blocking?
fileSizeThresholdClause? compactPool? (KW_WITH KW_OVERWRITE KW_TBLPROPERTIES
tableProperties)? whereClause? orderByClause?
+ -> ^(TOK_ALTERTABLE_COMPACT $compactType tableImplBuckets? blocking?
fileSizeThresholdClause? compactPool? tableProperties? whereClause?
orderByClause?)
Review Comment:
i don't think we should supply table properties via compaction command, we
should set it on table level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
