deniskuzZ commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1932569724
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -598,9 +605,10 @@ private void commitWrite(Table table, String branchName,
Long snapshotId, long s
* @param partitionPath The path of the compacted partition
*/
private void commitCompaction(Table table, Long snapshotId, long startTime,
FilesForCommit results,
- String partitionPath) {
- List<DataFile> existingDataFiles =
IcebergCompactionUtil.getDataFiles(table, partitionPath);
- List<DeleteFile> existingDeleteFiles =
IcebergCompactionUtil.getDeleteFiles(table, partitionPath);
+ String partitionPath, long fileSizeThreshold) {
+ List<DataFile> existingDataFiles =
IcebergCompactionUtil.getDataFiles(table, partitionPath, fileSizeThreshold);
+ List<DeleteFile> existingDeleteFiles = fileSizeThreshold == -1 ?
Review Comment:
we don't write deletes cause `-1` stands for MAJOR/FULL table/partition
compaction?
why not pass compaction type instead of `fileSizeThreshold`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
