difin commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1932738256
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergCompactionUtil.java:
##########
@@ -55,6 +60,12 @@ public static boolean shouldIncludeForCompaction(Table
table, String partitionPa
table.specs().get(file.specId()).partitionToPath(file.partition()).equals(partitionPath);
}
+ public static boolean shouldIncludeForCompaction(Table table, String
partitionPath, ContentFile<?> file,
Review Comment:
This method is used for Minor compaction which uses a file size threshold
clause. It is called from HiveIcebergOutputCommitter for finding data files
that need to be rewritten at commit time based on file size in bytes without
checking number of delete files.
In minor compaction we construct a compaction query with a data file size
threshold.
Even Amoro compaction evaluator doesn't check number of delete files of a
Fragment files, it is based on the Fragment file size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
