deniskuzZ commented on code in PR #5642:
URL: https://github.com/apache/hive/pull/5642#discussion_r1975612321


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java:
##########
@@ -1157,7 +1157,7 @@ private boolean checkAndCommitNatively(MoveWork moveWork, 
Configuration configur
     if (storageHandlerClass != null) {
       HiveStorageHandler storageHandler = 
HiveUtils.getStorageHandler(configuration, storageHandlerClass);
       if (storageHandler.commitInMoveTask()) {
-        storageHandler.storageHandlerCommit(commitProperties, operation);
+        storageHandler.storageHandlerCommit(commitProperties, operation, null);

Review Comment:
   please keep the original signature. add the default in the interface



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to