deniskuzZ commented on code in PR #5642:
URL: https://github.com/apache/hive/pull/5642#discussion_r1975631825
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -574,14 +585,24 @@ private void commitWrite(Table table, String branchName,
Long snapshotId, long s
}
write.validateDataFilesExist(results.referencedDataFiles());
write.validateNoConflictingDataFiles();
- write.commit();
+ commit(write);
}
LOG.info("Write commit took {} ms for table: {} with {} data and {} delete
file(s)",
System.currentTimeMillis() - startTime, table,
results.dataFiles().size(), results.deleteFiles().size());
LOG.debug("Added files {}", results);
}
+ /**
+ * Calls the commit on the prepared SnapshotUpdate and supplies the
ExecutorService if any.
+ * @param update the SnapshotUpdate of any kind (e.g. AppendFiles,
DeleteFiles, etc.)
+ */
+ private void commit(SnapshotUpdate<?> update) {
Review Comment:
this is an iceberg change commit, just implicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
