deniskuzZ commented on code in PR #5642:
URL: https://github.com/apache/hive/pull/5642#discussion_r1975615520
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -613,15 +614,17 @@ default boolean commitInMoveTask() {
* Commits the inserts for the non-native tables. Used in the {@link
org.apache.hadoop.hive.ql.exec.MoveTask}.
* @param commitProperties Commit properties which are needed for the
handler based commit
* @param operation the operation type
+ * @param suppliedExecutor an ExecutorService to be used by the
StorageHandler (optional)
* @throws HiveException If there is an error during commit
*/
- default void storageHandlerCommit(Properties commitProperties, Operation
operation) throws HiveException {
+ default void storageHandlerCommit(Properties commitProperties, Operation
operation, ExecutorService suppliedExecutor)
Review Comment:
1. keep original signature
````
default void storageHandlerCommit(Properties commitProperties, Operation
operation) {
storageHandlerCommit(commitProperties, operation,
ThreadPools.getWorkerPool())
}
````
2. `executorService`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
