abstractdog commented on code in PR #5648:
URL: https://github.com/apache/hive/pull/5648#discussion_r1977160682
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -285,6 +286,11 @@ default List<ColumnStatisticsObj>
getColStatistics(org.apache.hadoop.hive.ql.met
return null;
}
+ default AggrStats
getAggrColStatsFor(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
List<String> colNames,
Review Comment:
I think even if thia might look obvious, we need javadoc for all methods in
this interface
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -285,6 +286,11 @@ default List<ColumnStatisticsObj>
getColStatistics(org.apache.hadoop.hive.ql.met
return null;
}
+ default AggrStats
getAggrColStatsFor(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
List<String> colNames,
Review Comment:
I think even if this might look obvious, we need javadoc for all methods in
this interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
