abstractdog commented on code in PR #5648:
URL: https://github.com/apache/hive/pull/5648#discussion_r1977187165
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/TransformSpec.java:
##########
@@ -76,6 +90,28 @@ public String transformTypeString() {
return transformType.name();
}
+ public String toHiveExpr(Configuration conf, boolean alias) {
Review Comment:
this method looks testable, also it's a string magic which is hard to read
and understand, I would love to see a unit test with some test cases with input
confs -> output string pairs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
