abstractdog commented on code in PR #5648:
URL: https://github.com/apache/hive/pull/5648#discussion_r1977221717
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java:
##########
@@ -673,8 +672,8 @@ public ASTNode rewriteAST(ASTNode ast,
ColumnStatsAutoGatherContext context)
checkForPartitionColumns(colNames,
Utilities.getColumnNamesFromFieldSchema(tbl.getPartitionKeys()));
validateSpecifiedColumnNames(colNames);
- if (conf.getBoolVar(ConfVars.HIVE_STATS_COLLECT_PART_LEVEL_STATS) &&
tbl.isPartitioned()
- && !tbl.hasNonNativePartitionSupport()) {
+ if (conf.getBoolVar(ConfVars.HIVE_STATS_COLLECT_PART_LEVEL_STATS) &&
tbl.isPartitioned()
Review Comment:
this condition is used at least twice, does it make sense to put into a
separate method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
