abstractdog commented on code in PR #5666:
URL: https://github.com/apache/hive/pull/5666#discussion_r1987894147
##########
ql/src/java/org/apache/hadoop/hive/ql/queryhistory/repository/IcebergRepository.java:
##########
@@ -101,8 +112,14 @@ protected Table createTable(Hive hive, Database db) throws
HiveException {
return table;
}
+ @VisibleForTesting
+ int getSnapshotMaxAge() {
+ // expire/delete snapshots older than 1 day
+ return 24 * 60 * 60 * 1000;
Review Comment:
I would not use a HiveConf, because this only applies when the table is
first created, and from that point, the config is not effective (only if I
implement some alter table mechanism that overcomplicates this area), so a
HiveConf can make the user think the setting make its way magically any time,
but in fact, the assumption is that user will ALTER the table manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
