deniskuzZ commented on code in PR #5666:
URL: https://github.com/apache/hive/pull/5666#discussion_r1987679629
##########
ql/src/java/org/apache/hadoop/hive/ql/queryhistory/repository/IcebergRepository.java:
##########
@@ -101,8 +112,14 @@ protected Table createTable(Hive hive, Database db) throws
HiveException {
return table;
}
+ @VisibleForTesting
+ int getSnapshotMaxAge() {
+ // expire/delete snapshots older than 1 day
+ return 24 * 60 * 60 * 1000;
Review Comment:
that could be set on a table level -
`SNAPSHOT_MAX_AGE(history.expire.max-snapshot-age-ms)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
