deniskuzZ commented on code in PR #5699:
URL: https://github.com/apache/hive/pull/5699#discussion_r2005588766
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java:
##########
@@ -100,7 +102,15 @@ protected void initServer() {
// Server args
int maxMessageSize =
hiveConf.getIntVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_MAX_MESSAGE_SIZE);
- TThreadPoolServer.Args sargs = new
TThreadPoolServer.Args(serverSocket).processorFactory(processorFactory)
+ TThreadPoolServer.Args sargs = new TThreadPoolServer.Args(new
TServerSocket(serverSocket.getServerSocket()) {
Review Comment:
sorry, i did catch your point.
If I read it correctly, the anonymous class looks similar to
MetastoreTServerSocket except for the `keepAlive`.
Can't we extract it to the common module and reuse (pass keepAlive &
maxMessageSize as constructor args)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
