deniskuzZ commented on code in PR #5699:
URL: https://github.com/apache/hive/pull/5699#discussion_r2007320673
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -643,7 +584,21 @@ private static ThriftServer startBinaryMetastore(int port,
HadoopThriftAuthBridg
return thread;
});
- TThreadPoolServer.Args args = new TThreadPoolServer.Args(serverSocket)
+ TThreadPoolServer.Args args =
+ new TThreadPoolServer.Args(new
TServerSocket(serverSocket.getServerSocket()) {
+ @Override
+ public TSocket accept() throws TTransportException {
+ TSocket ts = super.accept();
+ // get the limit from the configuration for every new connection
+ int maxThriftMessageSize = (int) MetastoreConf.getSizeVar(
Review Comment:
I'll leave it to you, but in my opinion since the config is static there is
no need to reevaluate it on every new connection
you could parameterized the test and validate behaviour for diff inputs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
