dengzhhu653 commented on code in PR #5699:
URL: https://github.com/apache/hive/pull/5699#discussion_r2006712037
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreTServerSocket.java:
##########
@@ -29,8 +32,32 @@
* accepted sockets.
*
*/
-public class TServerSocketKeepAlive extends TServerSocket {
- public TServerSocketKeepAlive(TServerSocket serverSocket) throws
TTransportException {
+public class MetastoreTServerSocket extends TServerSocket {
+ private final Configuration configuration;
+
+ public MetastoreTServerSocket(TServerSocket serverSocket,
+ Configuration conf) throws TTransportException {
super(serverSocket.getServerSocket());
+ this.configuration = Objects.requireNonNull(conf);
+ }
+
+ @Override
+ public TSocket accept() throws TTransportException {
+ TSocket ts = super.accept();
+ boolean keepAlive = MetastoreConf.getBoolVar(configuration,
MetastoreConf.ConfVars.TCP_KEEP_ALIVE);
+ if (keepAlive) {
Review Comment:
After some check, the default `keepAlive` in thrift 0.16 is true,
https://github.com/apache/thrift/blob/0.16.0/lib/java/src/org/apache/thrift/transport/TSocket.java#L78,
so `KeepAlive` is always true whether `hive.metastore.server.tcp.keepalive` is
true or not based on
[HIVE-1410](https://issues.apache.org/jira/browse/HIVE-1410)
Since the `KeepAlive` helps HMS prevent the half-open connections, so it
would be good to enable it, so I would like to keep the
[HIVE-25098](https://issues.apache.org/jira/browse/HIVE-25098).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
