asolimando commented on code in PR #5795:
URL: https://github.com/apache/hive/pull/5795#discussion_r2068707661
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/SearchTransformer.java:
##########
@@ -128,8 +132,23 @@ public Shuttle(final RexBuilder rexBuilder) {
} else {
return call;
}
+ case IS_NULL:
+ case IS_NOT_NULL:
+ case CASE:
+ case COALESCE:
+ // Everything below must be transformed with the UNKNOWN handler
Review Comment:
I suspected something similar, thanks for the clarification.
Since this is a rather deep technical detail that most people not familiar
with CBO will have problems with, I'd suggest to have a more explicit comment
like "// These operator kinds require the UNKNOWN handler to correctly handle
NULL values" or something similar.
I know it's still a draft PR but for the rest LGTM already, feel free to
ping me for a review if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
