zabetak commented on code in PR #5795: URL: https://github.com/apache/hive/pull/5795#discussion_r2079014692
########## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/SearchTransformer.java: ########## @@ -128,8 +132,23 @@ public Shuttle(final RexBuilder rexBuilder) { } else { return call; } + case IS_NULL: + case IS_NOT_NULL: + case CASE: + case COALESCE: + // Everything below must be transformed with the UNKNOWN handler Review Comment: I added more comments and also made the approach a bit more defensive in the sense that if SEARCH happens to be under any operator other than AND/OR we don't perform the simplification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org