soumyakanti3578 commented on code in PR #5781:
URL: https://github.com/apache/hive/pull/5781#discussion_r2074384759


##########
iceberg/iceberg-handler/src/test/queries/positive/merge_with_null_check_on_joining_col.q:
##########
@@ -0,0 +1,24 @@
+
+create table target(a int, b int, c int) stored by iceberg 
tblproperties('format-version'='2', 'write.merge.mode'='copy-on-write');
+create table source(a int, b int, c int) stored by iceberg 
tblproperties('format-version'='2', 'write.merge.mode'='copy-on-write');

Review Comment:
   Unfortunately I was unable to reproduce this for native ACID tables. In the 
beginning I briefly looked at plan differences for MERGE statements between 
native and ICEBERG tables. For native tables it simply removes the `is null` 
condition from the plan somewhere. Also there were other differences like the 
use of `row__id`. I haven't looked into it in detail as the original issue was 
also on iceberg tables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to