kasakrisz commented on code in PR #5781:
URL: https://github.com/apache/hive/pull/5781#discussion_r2074956837


##########
iceberg/iceberg-handler/src/test/queries/positive/merge_with_null_check_on_joining_col.q:
##########
@@ -0,0 +1,24 @@
+
+create table target(a int, b int, c int) stored by iceberg 
tblproperties('format-version'='2', 'write.merge.mode'='copy-on-write');
+create table source(a int, b int, c int) stored by iceberg 
tblproperties('format-version'='2', 'write.merge.mode'='copy-on-write');

Review Comment:
   In case of Iceberg we support two types of delete implementations:
   * copy on write
   * merge on read
   In case of ACID only the latter exists.
   
   Both requires different strategies to rewrite the delete/update/merge 
statements.
   
   Since the bug affects only the copy-on-write implementation, it impacts only 
Iceberg tables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to