zabetak commented on code in PR #5781: URL: https://github.com/apache/hive/pull/5781#discussion_r2074895373
########## iceberg/iceberg-handler/src/test/queries/positive/merge_with_null_check_on_joining_col.q: ########## @@ -0,0 +1,24 @@ + +create table target(a int, b int, c int) stored by iceberg tblproperties('format-version'='2', 'write.merge.mode'='copy-on-write'); +create table source(a int, b int, c int) stored by iceberg tblproperties('format-version'='2', 'write.merge.mode'='copy-on-write'); Review Comment: If it only affects Iceberg tables then I guess the rewrite logic between Iceberg and ACID is different. Are the similarities between the rewrite classes for the two table formats? Can we take inspiration from the ACID part to fix the Iceberg problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org