wecharyu commented on code in PR #5780:
URL: https://github.com/apache/hive/pull/5780#discussion_r2085049414
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -662,7 +655,7 @@ public void rollbackTransaction() {
currentTransaction.rollback();
}
} finally {
- openTrasactionCalls = 0;
+ openTrasactionCalls--;
Review Comment:
Our unit test could not pass if is 0 here, the key point seems that if we
should support such usage:
```bash
openTransaction()
// new function1
{
openTransaction()
commitTransaction() # place1
}
// new function2
{
openTransaction()
commitTransaction()
}
commitTransaction() # place2
```
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -629,13 +622,13 @@ public boolean commitTransaction() {
LOG.error("Unbalanced calls to open/commit Transaction", e);
throw e;
}
- openTrasactionCalls--;
- debugLog("Commit transaction: count = " + openTrasactionCalls + ",
isactive "+ currentTransaction.isActive());
- if ((openTrasactionCalls == 0) && currentTransaction.isActive()) {
+ debugLog("Commit transaction: count = " + openTrasactionCalls + ",
isactive "+ currentTransaction.isActive());
+ if ((openTrasactionCalls == 1) && currentTransaction.isActive()) {
transactionStatus = TXN_STATUS.COMMITED;
currentTransaction.commit();
}
+ openTrasactionCalls--;
Review Comment:
If commit throw RuntimeException, it should call rollback in the finally
block of previous layer where the openTransactionCalls would be decreased.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -3254,31 +3247,38 @@ protected List<Partition>
getJdoResult(GetHelper<List<Partition>> ctx) throws Me
public Partition getPartitionWithAuth(String catName, String dbName, String
tblName,
List<String> partVals, String user_name, List<String> group_names)
throws NoSuchObjectException, MetaException, InvalidObjectException {
- boolean success = false;
- try {
- openTransaction();
- MPartition mpart = getMPartition(catName, dbName, tblName, partVals,
null);
- if (mpart == null) {
- commitTransaction();
- throw new NoSuchObjectException("partition values="
- + partVals.toString());
+ return new GetHelper<Partition>(catName, dbName, tblName, false, true) {
Review Comment:
It may throw exception, so we need such logic:
```java
try {
openTransaction();
success = commitTransaction();
} finally {
if (!success) rollbackTransaction();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
